Messages in this thread | | | Subject | Re: [PATCH 1/3] net:svc_rdma_transport: remove unneeded variable 'ret' in rdma_listen_handler | From | Anna Schumaker <> | Date | Tue, 7 Aug 2018 10:49:11 -0400 |
| |
(Adding Bruce since he takes nfs / sunrpc server patches)
On 08/07/2018 07:20 AM, zhong jiang wrote: > The ret is not modified after initalization, So just remove the variable > and return 0. > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> > --- > net/sunrpc/xprtrdma/svc_rdma_transport.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c > index 547b2cd..2848caf 100644 > --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c > +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c > @@ -296,7 +296,6 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id, > struct rdma_cm_event *event) > { > struct sockaddr *sap = (struct sockaddr *)&cma_id->route.addr.src_addr; > - int ret = 0; > > trace_svcrdma_cm_event(event, sap); > > @@ -315,7 +314,7 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id, > break; > } > > - return ret; > + return 0; > } > > static int rdma_cma_handler(struct rdma_cm_id *cma_id, >
| |