Messages in this thread | | | Date | Tue, 7 Aug 2018 15:38:55 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH] lib/vsprintf: Do not handle %pO[^F] as %px |
| |
On Mon 2018-08-06 15:34:21, Bart Van Assche wrote: > This patch avoids that gcc reports the following when building with W=1: > > lib/vsprintf.c:1941:3: warning: this statement may fall through [-Wimplicit-fallthrough=] > switch (fmt[1]) { > ^~~~~~ > > Fixes: ce4fecf1fe15 ("vsprintf: Add %p extension "%pOF" for device tree")
To be precise, the above commit was fine because it was the last "case" in "switch". It has got broken by the commit 7b1924a1d930eb2 ("vsprintf: add printk specifier %px").
Other than that the patch fixes a real problem. I have updated the "Fixes" tag, added stable tag and pushed it into printk.git, for-4.19 branch.
Best Regards, Petr
| |