Messages in this thread | | | Subject | Re: [PATCH 3/4] watchdog: hpwdt: Display module parameters. | From | Guenter Roeck <> | Date | Mon, 6 Aug 2018 19:28:46 -0700 |
| |
On 08/06/2018 04:19 PM, Jerry Hoemann wrote: > On Sat, Aug 04, 2018 at 06:13:20PM -0700, Guenter Roeck wrote: >> On 08/02/2018 02:15 PM, Jerry Hoemann wrote: >>> Print module parameters when the driver is loaded. >>> >>> Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com> >>> --- >>> drivers/watchdog/hpwdt.c | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c >>> index 8a85ddd..f098371 100644 >>> --- a/drivers/watchdog/hpwdt.c >>> +++ b/drivers/watchdog/hpwdt.c >>> @@ -326,8 +326,9 @@ static int hpwdt_init_one(struct pci_dev *dev, >>> } >>> dev_info(&dev->dev, "HPE Watchdog Timer Driver: %s" >>> - ", timer margin: %d seconds (nowayout=%d).\n", >>> - HPWDT_VERSION, hpwdt_dev.timeout, nowayout); >>> + ", timeout : %d seconds (nowayout=%d) pretimeout=%s.\n", >>> + HPWDT_VERSION, hpwdt_dev.timeout, nowayout, >>> + pretimeout ? "on" : "off"); >> When touching that, you might as well address >> >> WARNING: quoted string split across lines > > > k. Think I'll split into two dev_info calls as line is too long > to fit into 80 chars w/o splitting. > > >> >> Why did you add a space before ':' ? Personal preference ? > > I think you're referring to "timeout : %d seconds". Bad editting when > going from "timer margin:" to "timeout :". I'll fix. >
Yes, that is what I referred to.
> If you referring to the spaces around the ternary operator, that is > in coding-style although checkpatch accepts w/o spaces around the > operators. > Nope, those spaces are desirable.
Guenter
| |