lkml.org 
[lkml]   [2018]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] netlink: Don't shift on 64 for ngroups
From
From: Dmitry Safonov <dima@arista.com>
Date: Sun, 5 Aug 2018 00:55:44 +0100

> @@ -1011,8 +1011,8 @@ static int netlink_bind(struct socket *sock, struct sockaddr *addr,
>
> if (nlk->ngroups == 0)
> groups = 0;
> - else
> - groups &= (1ULL << nlk->ngroups) - 1;
> + else if (nlk->ngroups < sizeof(long unsigned int))
> + groups &= (1UL << nlk->ngroups) - 1;

Sizeof is in bytes, you want to compare against bits.

\
 
 \ /
  Last update: 2018-08-05 02:10    [W:0.043 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site