lkml.org 
[lkml]   [2018]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4.4 106/124] netlink: Do not subscribe to non-existent groups
From
From: Dmitry Safonov <dima@arista.com>
Date: Sun, 05 Aug 2018 00:26:38 +0100

> Thanks for the testing, sorry again for the breakage.
> Will send the patch shortly (with sizeof(unsigned long long) instead of
> hard-coded 64). Hopefully, not too late.

'groups' is "long unsigned int" not "unsigned long long"

long unsigned int groups = nladdr->nl_groups;

And nladdr->nl_groups is specified as "__u32"

So the size of the relevant bits is actually strictly 32-bit.

This makes also the "ULL" in your constant specification incorrect as
well.

So much crazy stuff going on here :-/

\
 
 \ /
  Last update: 2018-08-05 01:35    [W:0.094 / U:1.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site