[lkml]   [2018]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] ext4/mballoc: Remove unneeded variable "err"
On Sat, Aug 04, 2018 at 07:04:56PM +0800, zhong jiang wrote:
> The err is not used after initalization. So just remove the variable.
> Signed-off-by: zhong jiang <>

I'll apply this patch, but how did you generate the diff? The
function name here is all wrong:

> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 8b24d3d..e29fce2 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -3801,7 +3801,6 @@ static int ext4_mb_new_preallocation(struct ext4_allocation_context *ac)

The lines in question are from ext4_mb_release_inode_pa(), *not*
ext4_mb_new_preallocation(). So when I inspected the patch visually,
my first reaction was, "there's no way this patch would apply".

But then I looked at the C code changed by the patch, and I was
surprised to see that it applied correctly in a completely different
function, and when I regenerated the patch, the line numbers matched
yours --- so the only thing "wrong" in your patch is the function name.

So that raises the question --- how did you create the diff in this
patch? What version of git? And what version of the kernel?


- Ted

 \ /
  Last update: 2018-08-04 23:24    [W:0.053 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site