Messages in this thread | | | Subject | Re: [PATCH 01/23] infiniband: nes: add unlikely() to assert() | From | Doug Ledford <> | Date | Fri, 31 Aug 2018 10:06:59 -0400 |
| |
On Fri, 2018-08-31 at 01:34 +0300, Igor Stoppa wrote: > Typically the assert is expected to not fail. > > Signed-off-by: Igor Stoppa <igor.stoppa@huawei.com> > Cc: Chien Tung <chien.tin.tung@intel.com> > Cc: Roland Dreier <rolandd@cisco.com> > Cc: Faisal Latif <faisal.latif@intel.com> > Cc: Doug Ledford <dledford@redhat.com> > Cc: Jason Gunthorpe <jgg@ziepe.ca>
Acked-by: Doug Ledford <dledford@redhat.com>
> --- > drivers/infiniband/hw/nes/nes.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/nes/nes.h b/drivers/infiniband/hw/nes/nes.h > index bedaa02749fb..d2d0098f38e0 100644 > --- a/drivers/infiniband/hw/nes/nes.h > +++ b/drivers/infiniband/hw/nes/nes.h > @@ -151,7 +151,7 @@ do { \ > > #define assert(expr) \ > do { \ > - if (!(expr)) { \ > + if (unlikely(!(expr))) { \ > printk(KERN_ERR PFX "Assertion failed! %s, %s, %s, line %d\n", \ > #expr, __FILE__, __func__, __LINE__); \ > } \
-- Doug Ledford <dledford@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD[unhandled content-type:application/pgp-signature] | |