lkml.org 
[lkml]   [2018]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4 4/4] kvm: add a check if pfn is from NVDIMM pmem.
On 2018-08-30 at 12:07:11 -0700, Dave Hansen wrote:
> On 08/22/2018 03:58 AM, Zhang Yi wrote:
> > bool kvm_is_reserved_pfn(kvm_pfn_t pfn)
> > {
> > - if (pfn_valid(pfn))
> > - return PageReserved(pfn_to_page(pfn));
> > + struct page *page;
> > +
> > + if (pfn_valid(pfn)) {
> > + page = pfn_to_page(pfn);
> > + return PageReserved(page) && !is_dax_page(page);
> > + }
>
> This is in desperate need of commenting about what it is doing and why.
>
> The changelog alone doesn't cut it.
Thanks, Dave, Will add some comments

\
 
 \ /
  Last update: 2018-08-31 10:01    [W:0.074 / U:0.936 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site