lkml.org 
[lkml]   [2018]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2] EDAC, ghes: use CPER module handles to locate DIMMs
Date
Hi Tyler, 

> > +static int get_dimm_smbios_index(u16 handle) {
> > + struct mem_ctl_info *mci;
> > + int i;
> > +
> > + mci = ghes_pvt->mci;
> > +
>
> Minor nit: you could define and set mci in the same line to save some space
> here.
>
> Otherwise this patch looks good to me.

Good catch Tyler! I'll fix it.

Thanks,
Fan

> Reviewed-by: Tyler Baicar <baicar.tyler@gmail.com>

\
 
 \ /
  Last update: 2018-08-30 21:56    [W:0.112 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site