lkml.org 
[lkml]   [2018]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/2] dt-bindings: power: Add Spreadtrum SC2731 charger documentation
    Hi Krzysztof,

    On 29 August 2018 at 22:08, Krzysztof Kozlowski <krzk@kernel.org> wrote:
    > On Tue, 28 Aug 2018 at 11:04, Baolin Wang <baolin.wang@linaro.org> wrote:
    >>
    >> This patch adds the binding documentation for Spreadtrum SC2731 charger
    >> device.
    >>
    >> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
    >> ---
    >> .../bindings/power/supply/sc2731_charger.txt | 14 ++++++++++++++
    >> 1 file changed, 14 insertions(+)
    >> create mode 100644 Documentation/devicetree/bindings/power/supply/sc2731_charger.txt
    >>
    >> diff --git a/Documentation/devicetree/bindings/power/supply/sc2731_charger.txt b/Documentation/devicetree/bindings/power/supply/sc2731_charger.txt
    >> new file mode 100644
    >> index 0000000..02b616c
    >> --- /dev/null
    >> +++ b/Documentation/devicetree/bindings/power/supply/sc2731_charger.txt
    >> @@ -0,0 +1,14 @@
    >> +Spreadtrum SC2731 PMIC battery charger binding
    >> +
    >> +Required properties:
    >> + - compatible: Should be "sprd,sc2731-charger".
    >> + - reg: Address offset of charger register.
    >> + - phys: Contains a phandle to the USB phy.
    >> +
    >> +Example:
    >> +
    >> + charger@0 {
    >> + compatible = "sprd,sc2731-charger";
    >> + reg = <0x0>;
    >
    > Can you include also few lines of parent node? You use this "reg"
    > later as a base address so probably your parent node requires address
    > mapping. It would be nice to see it in example.
    >

    Sorry that I forgot adding the parent node, and will add it in next
    version. Thanks.

    --
    Baolin Wang
    Best Regards

    \
     
     \ /
      Last update: 2018-08-30 05:03    [W:3.030 / U:1.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site