lkml.org 
[lkml]   [2018]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 1/9] of: add helper to lookup compatible child node
    On Mon, Aug 27, 2018 at 3:22 AM Johan Hovold <johan@kernel.org> wrote:
    >
    > Add of_get_compatible_child() helper that can be used to lookup
    > compatible child nodes.
    >
    > Several drivers currently use of_find_compatible_node() to lookup child
    > nodes while failing to notice that the of_find_ functions search the
    > entire tree depth-first (from a given start node) and therefore can
    > match unrelated nodes. The fact that these functions also drop a
    > reference to the node they start searching from (e.g. the parent node)
    > is typically also overlooked, something which can lead to use-after-free
    > bugs.
    >
    > Signed-off-by: Johan Hovold <johan@kernel.org>
    > ---
    > drivers/of/base.c | 25 +++++++++++++++++++++++++
    > include/linux/of.h | 8 ++++++++
    > 2 files changed, 33 insertions(+)

    I've applied this one and plan to send to Linus tomorrow.

    Rob

    \
     
     \ /
      Last update: 2018-08-30 20:08    [W:4.109 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site