lkml.org 
[lkml]   [2018]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v5 1/4] gpiolib: Pass bitmaps, not integer arrays, to get/set array
    Date
    From: Miguel Ojeda
    > Sent: 30 August 2018 12:11
    ...
    > > + unsigned long value_bitmap[1]; /* for DATA[0-7], RS, RW */
    >
    > (I read your comments in the other email)
    >
    > I still find this odd, but if everyone is going to have this change
    > done like this, consistency is better.

    Maybe there ought to be a define so you can do:
    DEFINE_BITMAP(value_bitmap, 32);

    While it might just generate an unsigned long [] there is probably
    scope for stronger typing.

    David

    -
    Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
    Registration No: 1397386 (Wales)
    \
     
     \ /
      Last update: 2018-08-30 20:08    [W:4.180 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site