Messages in this thread | | | Date | Thu, 30 Aug 2018 07:40:10 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH 3/8] RISC-V: Rename riscv_of_processor_hart to riscv_of_processor_hartid |
| |
> +/* Returns the hart ID of the given device tree node, or -1 if the device tree > + * node isn't a RISC-V hart. */
In addition to the comment formatting: we usually keep the description near the implementation, not the header. It could also become a kerneldoc comment for added clarity.
> +extern int riscv_of_processor_hartid(struct device_node *node);
No need to declare function prototypes in headers with the extern attribute, btw.
| |