lkml.org 
[lkml]   [2018]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: LVM snapshot broke between 4.14 and 4.16
From
Date
Dne 2.8.2018 v 23:52 Linus Torvalds napsal(a):
> On Thu, Aug 2, 2018 at 2:39 PM WGH <wgh@torlan.ru> wrote:
>>
>> I've just found one public report of this bug, though:
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900442
>
> Yeah, it does sound like we should fix this issue.
>


Hi

IMHO (as the author of fixing lvm2 patch) user should not be upgrading kernels
and keep running older lvm2 user-land tool (and there are very good reasons
for this).

Kernel had a bug which has been fixed, lvm2 misused this kernel bug and was
also fixed. Keeping kernel bug present allowing certain device to write to
read-only devices can be possibly seen as some security risk.

Also the number of users who ever create a read-only snapshot is probably very
low.

Maybe there could be some 'dm-snapshot' loading modinfo option to allowing
to create in case user really wants to have this bug being present in kernel
(reinstantiate old buggy logic), but on default the user should get error when
it tries to write to read-only volume and should upgrade lvm2.

Regards

Zdenek

\
 
 \ /
  Last update: 2018-08-03 15:32    [W:0.010 / U:10.036 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site