Messages in this thread | | | Date | Wed, 29 Aug 2018 09:49:51 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] locking/lockdep: Delete unnecesary #include |
| |
On Wed, 29 Aug 2018 11:31:21 +0200 Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, Aug 28, 2018 at 09:33:15PM +0100, Ben Hutchings wrote: > > Commit c3bc8fd637a9 ("tracing: Centralize preemptirq tracepoints and u > > nify their usage") added the inclusion of <trace/events/preemptirq.h>. > > liblockdep doesn't have a stub version of that header so now fails to > > build. > > > > However, commit bff1b208a5d1 ("tracing: Partial revert of "tracing: > > Centralize preemptirq tracepoints and unify their usage"") removed the > > use of functions declared in that header. So delete the #include. > > > > Fixes: c3bc8fd637a9 ("tracing: Centralize preemptirq tracepoints ...") > > Fixes: bff1b208a5d1 ("tracing: Partial revert of "tracing: Centralize ...") > > There's no actual breakage because of this extra include, is there?
I believe the user tool in tools/lib/lockdep fails because of it. Although, I just tried building it myself, and it fails because of nmi.h header file.
-- Steve
| |