lkml.org 
[lkml]   [2018]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/3] ata: libahci_platform: add reset control support
On Wed, Aug 22, 2018 at 09:13:02PM +0900, Kunihiko Hayashi wrote:
> Add support to get and control a list of resets for the device
> as optional and shared. These resets must be kept de-asserted until
> the device is enabled.
>
> This is specified as shared because some SoCs like UniPhier series
> have common reset controls with all ahci controller instances.
>
> However, according to Thierry's view,
> https://www.spinics.net/lists/linux-ide/msg55357.html
> some hardware-specific drivers already use their own resets,
> and the common reset make a path to occur double controls of resets.
>
> The ahci_platform_get_resources() can get and control the reset
> only when the second argument includes AHCI_PLATFORM_GET_RESETS bit.
>
> Suggested-by: Hans de Goede <hdegoede@redhat.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../devicetree/bindings/ata/ahci-platform.txt | 1 +

Acked-by: Rob Herring <robh@kernel.org>

> drivers/ata/ahci.h | 1 +
> drivers/ata/libahci_platform.c | 31 ++++++++++++++++++----
> include/linux/ahci_platform.h | 2 ++
> 4 files changed, 30 insertions(+), 5 deletions(-)

\
 
 \ /
  Last update: 2018-08-29 02:34    [W:0.129 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site