Messages in this thread | | | Date | Sun, 26 Aug 2018 16:28:43 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH v2 03/32] selftests/ftrace: Add --console hidden option |
| |
On Fri, 24 Aug 2018 21:42:04 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:
> On Sat, 25 Aug 2018 10:35:13 +0900 > Masami Hiramatsu <mhiramat@kernel.org> wrote: > > > On Fri, 24 Aug 2018 16:37:37 -0400 > > Steven Rostedt <rostedt@goodmis.org> wrote: > > > > > On Fri, 17 Aug 2018 01:30:36 +0900 > > > Masami Hiramatsu <mhiramat@kernel.org> wrote: > > > > > > > Add --console hidden option for debug test cases. > > > > This option allows to put "sh" or something else > > > > when the test case hits a bug. > > > > > > Can you add more information to why and how this would be used. > > > > For example, if you find a testcase which doesn't > > pass, you can insert sh for interactive debug as below > > > > #!/bin/sh > > # description: sample test case > > > > good-command > > suspicious-wrong-command > > sh # <- add this for interactive debug > > > > Ah! OK. But this needs to be explained a little better in the change > log as well as in the comments for it.
Ah sorry I missed "I will add following example"... yes, of course I add this to description.
Thank you,
> > Thanks! > > -- Steve
-- Masami Hiramatsu <mhiramat@kernel.org>
| |