Messages in this thread | | | From | Anders Roxell <> | Date | Fri, 24 Aug 2018 15:07:03 +0200 | Subject | Re: [PATCH] fs/ocfs2/dlmglue: lockdep_keys defined but not used |
| |
On Thu, 23 Aug 2018 at 23:07, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Anders, > > On Wed, Jul 4, 2018 at 11:54 AM Anders Roxell <anders.roxell@linaro.org> wrote: > > When CONFIG_DEBUG_LOCK_ALLOC isn't enabled lockdep_keys isn't used and > > we get a warning: > > fs/ocfs2/dlmglue.c:99:30: warning: ‘lockdep_keys’ defined but not used > > [-Wunused-variable] > > static struct lock_class_key lockdep_keys[OCFS2_NUM_LOCK_TYPES]; > > ^~~~~~~~~~~~ > > Adding __maybe_unused to the declaration hids the warning. > > Thanks for your patcj! > > > Fixes: 1cd75cdb8fbb ("ocfs2: make several functions and variables static (and some const)") > > Fixes: 480bd56485b77c36 ("ocfs2: make several functions and variables > static (and some const)")
Thanks, thats correct.
> > Presumably the branch got rebased?
probably.
Mark, Joel, do you want me to send a new patch where I correct the sha in the "Fixes" part of the changelog or can you fix that?
Cheers, Anders
> > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
| |