Messages in this thread | | | Date | Fri, 24 Aug 2018 11:55:15 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v5 1/2] dt-bindings: leds: Add bindings for lm3697 driver |
| |
On Fri 2018-08-17 10:15:27, Dan Murphy wrote: > Add the device tree bindings for the lm3697 > LED driver for backlighting and display. > > Signed-off-by: Dan Murphy <dmurphy@ti.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Some nits are below.
> +The LM3697 11-bit LED driver provides high- > +performance backlight dimming for 1, 2, or 3 series > +LED strings while delivering up to 90% efficiency.
LED core is 8-bit only... so full dynamic range can not be currently used in linux -- right? Is there any plan to change/fix that?
> +This device is suitable for Display and Keypad Lighting
"display and keypad lighting."
> +Optional properties: > + - enable-gpios : gpio pin to enable/disable the device.
Remove "." at end of sentence, for consistency. "GPIO"?
> +All HVLED strings controlled by control bank A
":"?
> +led-controller@36 { > + compatible = "ti,lm3967"; > + reg = <0x36>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; > + vled-supply = <&vbatt>; > + > + led@0 { > + reg = <0>; > + led-sources = <1 1 1>; > + label = "white:backlight_cluster"; > + linux,default-trigger = "backlight"; > + }; > +} > + > +For more product information please see the link below: > +http://www.ti.com/lit/ds/symlink/lm3697.pdf
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |