Messages in this thread | | | Subject | Re: [PATCH] compiler-gcc: get back Clang build | From | Joe Perches <> | Date | Wed, 22 Aug 2018 16:32:09 -0700 |
| |
On Wed, 2018-08-22 at 16:05 -0700, Nick Desaulniers wrote:
Hey Nick.
> On Wed, Aug 22, 2018 at 1:50 PM Joe Perches <joe@perches.com> wrote: > > A mild suggestion about the patch would be to break it up into > > 2 patches to improve how people read and review them. > > > > 1 include/linux/compiler-* > > 2 everything else > > > > Yes, some kernel configs might not build properly between 1 and 2 > > but that likely doesn't matter as those configs probably don't > > build before 1 either. > > If we ordered the patches so that the "everything else" went in first, > it would not be a problem. The first patch would just be the checks > that GCC_VERSION is defined. > > In general, I'm happy to split patches, but in this suggested case, it > only shaves off 26 lines from the main body of work.
No worries, I rarely care _that_ much about code, but seeing the subject with compiler-gcc and the first part of the patch about arch/ was a bit off-putting.
You're the one doing the work here. Do what you think best.
| |