Messages in this thread | | | Date | Wed, 22 Aug 2018 18:17:41 +0200 | From | Jan Kara <> | Subject | Re: [PATCH 1/2] fs/quota: Replace XQM_MAXQUOTAS usage with MAXQUOTAS |
| |
On Wed 22-08-18 18:05:51, Jan Kara wrote: > On Tue 31-07-18 01:37:30, Jeremy Cline wrote: > > XQM_MAXQUOTAS and MAXQUOTAS are, it appears, equivalent. Replace all > > usage of XQM_MAXQUOTAS and remove it along with the unused XQM_*QUOTA > > definitions. > > > > Signed-off-by: Jeremy Cline <jcline@redhat.com> > > Thanks for the cleanup. The patch looks good, just one small nit: > > > diff --git a/include/uapi/linux/dqblk_xfs.h b/include/uapi/linux/dqblk_xfs.h > > index 03d890b80ebc..a5846cde8272 100644 > > --- a/include/uapi/linux/dqblk_xfs.h > > +++ b/include/uapi/linux/dqblk_xfs.h > > @@ -27,11 +27,6 @@ > > #define XQM_CMD(x) (('X'<<8)+(x)) /* note: forms first QCMD argument */ > > #define XQM_COMMAND(x) (((x) & (0xff<<8)) == ('X'<<8)) /* test if for XFS */ > > You can delete XQM_COMMAND() as well here. > > > -#define XQM_USRQUOTA 0 /* system call user quota type */ > > -#define XQM_GRPQUOTA 1 /* system call group quota type */ > > -#define XQM_PRJQUOTA 2 /* system call project quota type */ > > -#define XQM_MAXQUOTAS 3 > > -
Oh, now I've realized that these are actually from uapi header. I don't think it's worth to break existing userspace sources just for a sake of this small cleanup. So I'll just remove this hunk from the patch.
Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |