Messages in this thread | | | Subject | Re: [PATCH] RDMA/smc: Replace ib_query_gid with rdma_get_gid_attr | From | Hans Wippel <> | Date | Wed, 22 Aug 2018 16:19:37 +0200 |
| |
On 08/18/2018 04:17 AM, Jason Gunthorpe wrote: > All RDMA ULPs should be using rdma_get_gid_attr instead of > ib_query_gid. Convert SMC to use the new API. > > In the process correct some confusion with gid_type - if attr->ndev is > !NULL then gid_type can never be IB_GID_TYPE_IB by > definition. IB_GID_TYPE_ROCE shares the same enum value and is probably > what was intended here. > > Reviewed-by: Parav Pandit <parav@mellanox.com> > Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
I ran a few SMC tests and the changes look good. So, no objections from our side and thank you for the patch.
Hans
| |