lkml.org 
[lkml]   [2018]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] cpuidle: menu: Retain tick when shallow state is selected
    On Wed, Aug 22, 2018 at 08:02:00PM +0800, Leo Yan wrote:

    [...]

    > > + if (!tick_nohz_tick_stopped()) {
    > > + /*
    > > + * If the state selected so far is shallow,
    > > + * waking up early won't hurt, so retain the
    > > + * tick in that case and let the governor run
    > > + * again in the next iteration of the loop.
    > > + */
    > > + expected_interval = drv->states[idx].target_residency;
    > > + break;
    > > + }
    > > +
    >
    > This is reliable, how we can rely on a shallow idle state target
    > residency to decide if need to stop a tick or not?

    s/This is reliable/This isn't reliable

    >
    > > /*
    > > * If the state selected so far is shallow and this
    > > * state's target residency matches the time till the
    > >

    \
     
     \ /
      Last update: 2018-08-22 14:04    [W:2.334 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site