Messages in this thread | | | Date | Wed, 22 Aug 2018 12:09:36 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v4 1/4] staging: mt7621-mmc: Fix debug macro N_MSG |
| |
On Wed, Aug 22, 2018 at 02:04:55PM +0530, Nishad Kamdar wrote: > This patch fixes the debug macro N_MSG. Replaces printk with > dev_<level> without __func__ or __LINE__ or current->comm and > current->pid. Removes the do {} while(0) loop for the single > statement macro. Issue found by checkpatch. > > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com> > --- > drivers/staging/mt7621-mmc/dbg.h | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/mt7621-mmc/dbg.h b/drivers/staging/mt7621-mmc/dbg.h > index 2f2c56b73987..c56fb896617a 100644 > --- a/drivers/staging/mt7621-mmc/dbg.h > +++ b/drivers/staging/mt7621-mmc/dbg.h > @@ -104,13 +104,10 @@ do { \ > > #define N_MSG(evt, fmt, args...) > /* > -do { \ > - if ((DBG_EVT_##evt) & sd_debug_zone[host->id]) { \ > - printk(KERN_ERR TAG"%d -> "fmt" <- %s() : L<%d> PID<%s><0x%x>\n", \ > - host->id, ##args , __FUNCTION__, __LINE__, current->comm, current->pid); \ > - } \ > -} while(0) > -*/ > + *if ((DBG_EVT_##evt) & sd_debug_zone[host->id]) { \ > + * dev_err(mmc_dev(host->mmc), "%d -> " fmt "\n", host->id, ##args) \ > + *} > + */
I don't understand what you're trying to do here. You just commented out the macro and turned it into a no-op. That's not what the patch description says.
To me the original code seems fine.
regards, dan carpenter
| |