lkml.org 
[lkml]   [2018]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/4] venus: firmware: move load firmware in a separate function
Hi Stanimir,

On 2018-08-21 17:38, Stanimir Varbanov wrote:
> Hi Vikash,
>
> On 08/06/2018 04:28 PM, Vikash Garodia wrote:

<snip>

>> -int venus_boot(struct device *dev, const char *fwname)
>> +static int venus_load_fw(struct venus_core *core, const char *fwname,
>> + phys_addr_t *mem_phys, size_t *mem_size)
>
> fix indentation
Please let me know which indentation rule is missed out here. As per
last
discussion, the parameters on next line should start from open
parenthesis.
I see the same being followed above.
Also i have been running checkpatch script and it does not show up any
issue.
Any other script which can be executed to ensure the coding guidelines ?

<snip>

>>
>> - ret = qcom_mdt_load(dev, mdt, fwname, VENUS_PAS_ID, mem_va,
>> mem_phys,
>> - mem_size, NULL);
>> + if (core->no_tz)
>> + ret = qcom_mdt_load_no_init(dev, mdt, fwname, VENUS_PAS_ID,
>> + mem_va, *mem_phys, *mem_size, NULL);
>> + else
>> + ret = qcom_mdt_load(dev, mdt, fwname, VENUS_PAS_ID,
>> + mem_va, *mem_phys, *mem_size, NULL);
>
> Please fix the indentation issues above.
Please specify here as well.

>>
>> release_firmware(mdt);
>>
>> - if (ret)
>> - goto err_unmap;
>> -
>> - ret = qcom_scm_pas_auth_and_reset(VENUS_PAS_ID);
>> - if (ret)
>> - goto err_unmap;
>> -
>> err_unmap:
>> memunmap(mem_va);
>> return ret;
>> }
>>
>> +int venus_boot(struct venus_core *core)
>> +{
>> + phys_addr_t mem_phys;
>> + struct device *dev = core->dev;
>
> move this one row upper.
>
>> + size_t mem_size;
>> + int ret;
>> +
>> + if (!IS_ENABLED(CONFIG_QCOM_MDT_LOADER) ||
>> + (!core->no_tz && !qcom_scm_is_available()))
>> + return -EPROBE_DEFER;
>
> fix indentation
Please specify here as well.

Thanks,
Vikash

\
 
 \ /
  Last update: 2018-08-21 19:31    [W:1.468 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site