lkml.org 
[lkml]   [2018]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/2] drm: rcar-du: Refactor Feature and Quirk definitions
    Date
    These flags are represented by bit fields. To make this clear, utilise
    the BIT() macro.

    Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

    ---
    This patch fails checkpatch's 80-char limit, due to the line comments
    extending across the 80-char boundary on RCAR_DU_FEATURE_EXT_CTRL_REGS

    To preserve formatting - this warning has been ignored.

    drivers/gpu/drm/rcar-du/rcar_du_drv.h | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.h b/drivers/gpu/drm/rcar-du/rcar_du_drv.h
    index b3a25e8e07d0..78ea20abfb30 100644
    --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.h
    +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.h
    @@ -27,11 +27,11 @@ struct drm_device;
    struct drm_fbdev_cma;
    struct rcar_du_device;

    -#define RCAR_DU_FEATURE_CRTC_IRQ_CLOCK (1 << 0) /* Per-CRTC IRQ and clock */
    -#define RCAR_DU_FEATURE_EXT_CTRL_REGS (1 << 1) /* Has extended control registers */
    -#define RCAR_DU_FEATURE_VSP1_SOURCE (1 << 2) /* Has inputs from VSP1 */
    +#define RCAR_DU_FEATURE_CRTC_IRQ_CLOCK BIT(0) /* Per-CRTC IRQ and clock */
    +#define RCAR_DU_FEATURE_EXT_CTRL_REGS BIT(1) /* Has extended control registers */
    +#define RCAR_DU_FEATURE_VSP1_SOURCE BIT(2) /* Has inputs from VSP1 */

    -#define RCAR_DU_QUIRK_ALIGN_128B (1 << 0) /* Align pitches to 128 bytes */
    +#define RCAR_DU_QUIRK_ALIGN_128B BIT(0) /* Align pitches to 128 bytes */

    /*
    * struct rcar_du_output_routing - Output routing specification
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-08-20 18:01    [W:3.456 / U:1.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site