Messages in this thread | | | Subject | Re: [PATCH] lightnvm: pblk: take write semaphore on metadata | From | Jens Axboe <> | Date | Thu, 2 Aug 2018 09:57:40 -0600 |
| |
On 8/2/18 7:47 AM, Javier González wrote: > Take the write semaphore on metadata I/Os too.
I'm going to nit pick a little bit here, but this isn't a good changelog at all. A good changelog tells you _why_ a change is made, not how it's made. Your commit message doesn't really tell me anything that I can't easily glean from looking at the patch.
A good commit message would tell me _why_ we are now also grabbing the write sem for metadata.
-- Jens Axboe
| |