lkml.org 
[lkml]   [2018]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 09/14] sched: Add over-utilization/tipping point indicator
On Tue, Jul 24, 2018 at 01:25:16PM +0100, Quentin Perret wrote:
> @@ -5100,8 +5118,17 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags)
> update_cfs_group(se);
> }
>
> - if (!se)
> + if (!se) {
> add_nr_running(rq, 1);
> + /*
> + * The utilization of a new task is 'wrong' so wait for it
> + * to build some utilization history before trying to detect
> + * the overutilized flag.
> + */
> + if (flags & ENQUEUE_WAKEUP)
> + update_overutilized_status(rq);
> +
> + }
>
> hrtick_update(rq);
> }

That is a somewhat dodgy hack. There is no guarantee what so ever that
when the task wakes next its history is any better. The comment doesn't
reflect this I feel.

\
 
 \ /
  Last update: 2018-08-02 14:27    [W:0.210 / U:2.880 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site