lkml.org 
[lkml]   [2018]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/urgent] perf annotate: Make local period the default percent type
    Commit-ID:  addba8b66f9101b0e55a151fc543ff35990bc8ef
    Gitweb: https://git.kernel.org/tip/addba8b66f9101b0e55a151fc543ff35990bc8ef
    Author: Jiri Olsa <jolsa@kernel.org>
    AuthorDate: Sat, 4 Aug 2018 15:05:18 +0200
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Wed, 8 Aug 2018 15:55:52 -0300

    perf annotate: Make local period the default percent type

    Currently we display the percentages in annotation output based on
    number of samples hits. Switching it to period based percentage by
    default, because it corresponds more to the time spent on the line.

    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Link: http://lkml.kernel.org/r/20180804130521.11408-18-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/annotate.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
    index 850958bb613a..05d15629afd0 100644
    --- a/tools/perf/util/annotate.c
    +++ b/tools/perf/util/annotate.c
    @@ -49,7 +49,7 @@ struct annotation_options annotation__default_options = {
    .jump_arrows = true,
    .annotate_src = true,
    .offset_level = ANNOTATION__OFFSET_JUMP_TARGETS,
    - .percent_type = PERCENT_HITS_LOCAL,
    + .percent_type = PERCENT_PERIOD_LOCAL,
    };

    static regex_t file_lineno;
    \
     
     \ /
      Last update: 2018-08-18 13:35    [W:3.304 / U:23.868 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site