lkml.org 
[lkml]   [2018]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[tip:perf/urgent] perf annotate: Add PERCENT_HITS_GLOBAL percent value
Commit-ID:  75a8c1ff287b2a949b50c1c1e58a6492e21a3ac5
Gitweb: https://git.kernel.org/tip/75a8c1ff287b2a949b50c1c1e58a6492e21a3ac5
Author: Jiri Olsa <jolsa@kernel.org>
AuthorDate: Sat, 4 Aug 2018 15:05:10 +0200
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 8 Aug 2018 15:55:48 -0300

perf annotate: Add PERCENT_HITS_GLOBAL percent value

Adding and computing global hits percent value for annotation line.
Storing it in struct annotation_data percent array under new
PERCENT_HITS_GLOBAL index.

At the moment it's not displayed, it's coming in following patches.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/20180804130521.11408-10-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/annotate.c | 8 +++++++-
tools/perf/util/annotate.h | 1 +
2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 074adb2a831e..b7485a512da1 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -1759,6 +1759,7 @@ out_close_stdout:
}

static void calc_percent(struct sym_hist *sym_hist,
+ struct hists *hists,
struct annotation_data *data,
s64 offset, s64 end)
{
@@ -1776,6 +1777,10 @@ static void calc_percent(struct sym_hist *sym_hist,
data->he.nr_samples = hits;
data->percent[PERCENT_HITS_LOCAL] = 100.0 * hits / sym_hist->nr_samples;
}
+
+ if (hists->stats.nr_non_filtered_samples)
+ data->percent[PERCENT_HITS_GLOBAL] = 100.0 * hits / hists->stats.nr_non_filtered_samples;
+
}

static void annotation__calc_percent(struct annotation *notes,
@@ -1795,6 +1800,7 @@ static void annotation__calc_percent(struct annotation *notes,
end = next ? next->offset : len;

for_each_group_evsel(evsel, leader) {
+ struct hists *hists = evsel__hists(evsel);
struct annotation_data *data;
struct sym_hist *sym_hist;

@@ -1803,7 +1809,7 @@ static void annotation__calc_percent(struct annotation *notes,
sym_hist = annotation__histogram(notes, evsel->idx);
data = &al->data[i++];

- calc_percent(sym_hist, data, al->offset, end);
+ calc_percent(sym_hist, hists, data, al->offset, end);
}
}
}
diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h
index 0afbf8075fca..3a06cb2b6e28 100644
--- a/tools/perf/util/annotate.h
+++ b/tools/perf/util/annotate.h
@@ -103,6 +103,7 @@ struct sym_hist_entry {

enum {
PERCENT_HITS_LOCAL,
+ PERCENT_HITS_GLOBAL,
PERCENT_MAX,
};

\
 
 \ /
  Last update: 2018-08-18 13:31    [W:0.202 / U:2.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site