Messages in this thread | | | Date | Fri, 17 Aug 2018 09:09:27 -0600 | From | Rob Herring <> | Subject | Re: [PATCH v12 14/14] cpufreq: qcom: Add support for krait based socs |
| |
Hi, this email is from Rob's (experimental) review bot. I found a couple of common problems with your patch. Please see below.
On Tue, 14 Aug 2018 17:42:33 +0530, Sricharan R wrote: > In Certain QCOM SoCs like ipq8064, apq8064, msm8960, msm8974 > that has KRAIT processors the voltage/current value of each OPP > varies based on the silicon variant in use. > > The required OPP related data is determined based on > the efuse value. This is similar to the existing code for > kryo cores. So adding support for krait cores here. > > Signed-off-by: Sricharan R <sricharan@codeaurora.org>
The preferred subject prefix is "dt-bindings: <binding dir>: ...".
> --- > .../devicetree/bindings/opp/qcom-nvmem-cpufreq.txt | 3 +- > drivers/cpufreq/Kconfig.arm | 2 +- > drivers/cpufreq/cpufreq-dt-platdev.c | 5 + > drivers/cpufreq/qcom-cpufreq-nvmem.c | 151 +++++++++++++++++++-- > 4 files changed, 149 insertions(+), 12 deletions(-) >
DT bindings (including binding headers) should be a separate patch. See Documentation/devicetree/bindings/submitting-patches.txt.
| |