lkml.org 
[lkml]   [2018]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] Input: fix irqf_oneshot.cocci warnings
From: kbuild test robot <fengguang.wu@intel.com>

drivers/input/misc/da7280.c:1335:7-32: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
threaded IRQs without a primary handler need to be requested with
IRQF_ONESHOT, otherwise the request will fail.

So pass the IRQF_ONESHOT flag in this case.

Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci

Fixes: a067f5d53e35 ("Input: new da7280 haptic driver")
CC: Roy Im <roy.im.opensource@diasemi.com>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---

Please take the patch only if it's a positive warning. Thanks!

da7280.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/input/misc/da7280.c
+++ b/drivers/input/misc/da7280.c
@@ -1334,7 +1334,7 @@ static int da7280_probe(struct i2c_clien

ret = devm_request_threaded_irq(dev, client->irq, NULL,
da7280_irq_handler,
- DA7280_IRQ_FLAGS,
+ DA7280_IRQ_FLAGS | IRQF_ONESHOT,
"da7280-haptics", haptics);
if (ret != 0) {
dev_err(dev,
\
 
 \ /
  Last update: 2018-08-16 08:47    [W:0.688 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site