lkml.org 
[lkml]   [2018]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V4 5/8] backlight: qcom-wled: Restructure the driver for WLED3
    On 2018-08-07 11:07, Bjorn Andersson wrote:
    > On Mon 09 Jul 03:22 PDT 2018, Kiran Gunda wrote:
    >> diff --git a/drivers/video/backlight/qcom-wled.c
    >> b/drivers/video/backlight/qcom-wled.c
    > [..]
    >> @@ -365,6 +434,15 @@ static int wled_configure(struct wled *wled,
    >> struct device *dev)
    >>
    >> cfg->num_strings = cfg->num_strings + 1;
    >>
    >> + string_len = of_property_count_elems_of_size(dev->of_node,
    >> + "qcom,enabled-strings",
    >> + sizeof(u32));
    >> + if (string_len > 0)
    >> + rc = of_property_read_u32_array(dev->of_node,
    >> + "qcom,enabled-strings",
    >> + wled->cfg.enabled_strings,
    >
    > qcom,enabled-strings is listed as optional, but without it we will end
    > up with qcom,num-strings zeros in an array. Initialize
    > wled->cfg.enabled_strings to 0,1,2,3 and the driver will be backwards
    > compatible.
    >
    Correct. I will initialize the array in the next series.
    > I also think that if you do qcom,enabled-strings = <0, 1, 2>; there's
    > no
    > need to also specify qcom,num-strings = <3>; and we can just use
    > string_len for num_strings.
    Correct. But I have kept this property to have the backward
    compatibility with the
    old driver (WLED3).
    >
    >> + sizeof(u32));
    >> +
    >> return 0;
    >> }
    >
    > Regards,
    > Bjorn
    > --
    > To unsubscribe from this list: send the line "unsubscribe
    > linux-arm-msm" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html

    \
     
     \ /
      Last update: 2018-08-16 07:30    [W:3.620 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site