lkml.org 
[lkml]   [2018]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v3 4/4] mm/memory_hotplug: Drop node_online check in unregister_mem_sect_under_nodes
    Date
    On 18-08-15 16:42:19, Oscar Salvador wrote:
    > From: Oscar Salvador <osalvador@suse.de>
    >
    > We are getting the nid from the pages that are not yet removed,
    > but a node can only be offline when its memory/cpu's have been removed.
    > Therefore, we know that the node is still online.

    Reviewed-by: Pavel Tatashin <pavel.tatashin@microsoft.com>

    >
    > Signed-off-by: Oscar Salvador <osalvador@suse.de>
    > ---
    > drivers/base/node.c | 2 --
    > 1 file changed, 2 deletions(-)
    >
    > diff --git a/drivers/base/node.c b/drivers/base/node.c
    > index 81b27b5b1f15..b23769e4fcbb 100644
    > --- a/drivers/base/node.c
    > +++ b/drivers/base/node.c
    > @@ -465,8 +465,6 @@ void unregister_mem_sect_under_nodes(struct memory_block *mem_blk,
    >
    > if (nid < 0)
    > continue;
    > - if (!node_online(nid))
    > - continue;
    > /*
    > * It is possible that NODEMASK_ALLOC fails due to memory
    > * pressure.
    > --
    > 2.13.6
    >
    \
     
     \ /
      Last update: 2018-08-16 21:00    [W:5.365 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site