Messages in this thread | | | From | Pasha Tatashin <> | Subject | Re: [PATCH v3 1/4] mm/memory-hotplug: Drop unused args from remove_memory_section | Date | Thu, 16 Aug 2018 17:45:43 +0000 |
| |
On 18-08-15 16:42:16, Oscar Salvador wrote: > From: Oscar Salvador <osalvador@suse.de> > > unregister_memory_section() calls remove_memory_section() > with three arguments: > > * node_id > * section > * phys_device > > Neither node_id nor phys_device are used. > Let us drop them from the function.
Looks good: Reviewed-by: Pavel Tatashin <pavel.tatashin@microsoft.com>
> > Signed-off-by: Oscar Salvador <osalvador@suse.de> > Reviewed-by: David Hildenbrand <david@redhat.com> > Reviewed-by: Andrew Morton <akpm@linux-foundation.org> > --- > drivers/base/memory.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c > index c8a1cb0b6136..2c622a9a7490 100644 > --- a/drivers/base/memory.c > +++ b/drivers/base/memory.c > @@ -752,8 +752,7 @@ unregister_memory(struct memory_block *memory) > device_unregister(&memory->dev); > } > > -static int remove_memory_section(unsigned long node_id, > - struct mem_section *section, int phys_device) > +static int remove_memory_section(struct mem_section *section) > { > struct memory_block *mem; > > @@ -785,7 +784,7 @@ int unregister_memory_section(struct mem_section *section) > if (!present_section(section)) > return -EINVAL; > > - return remove_memory_section(0, section, 0); > + return remove_memory_section(section); > } > #endif /* CONFIG_MEMORY_HOTREMOVE */ > > -- > 2.13.6 >
| |