lkml.org 
[lkml]   [2018]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] dt-bindings: phy-rockchip-inno-usb2: add new rockchip,force-bvalid property.
On Wed, Aug 15, 2018 at 11:59:34AM +0200, Enric Balletbo i Serra wrote:
> This property is used when the otg-id pin is not connected. When this
> property is set it forces to set the B-Device Session Valid bit when the
> port works as device and clears that bit when the port works as host.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> .../devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
> index 2d4808d3920b..55761f466c41 100644
> --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
> @@ -48,6 +48,11 @@ Optional properties:
> See ./phy-bindings.txt for details.
> - rockchip,utmi-avalid : boolean, use the avalid register to get vbus status.
> Otherwise, use the bvalid register.
> + - rockchip,force-bvalid : boolean, set this to force the B-Device Session
> + Valid bit when the usb port is in device mode. This
> + is used when the otg-id pin is not connected.
> + Only supported in case of compatible being:
> + * "rockchip,rk3399-usb2phy"

Shouldn't you describe the property of the h/w that ID pin is not
connected, rather than what you do with that information.

Is the pin not connected because it's a connector without ID pin? If so,
that should be a property of the connector (or inferred from the
connector compatible string).

Rob

\
 
 \ /
  Last update: 2018-08-16 00:26    [W:0.128 / U:3.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site