Messages in this thread | | | Date | Tue, 14 Aug 2018 13:16:02 -0700 | From | Brian Norris <> | Subject | Re: [PATCH] bluetooth/{bnep,cmtp,hidp}: Remove unnecessary smp_mb__{before,after}_atomic |
| |
On Tue, Aug 14, 2018 at 08:41:06PM +0200, Andrea Parri wrote: > The barriers are unneeded; wait_woken() and woken_wake_function() > already provide us with the required synchronization: remove them > and document that we're relying on the (implicit) synchronization > provided by wait_woken() and woken_wake_function(). > > Signed-off-by: Andrea Parri <andrea.parri@amarulasolutions.com> > --- > net/bluetooth/bnep/core.c | 7 ++++--- > net/bluetooth/cmtp/core.c | 14 ++++++++------ > net/bluetooth/hidp/core.c | 13 ++++++++----- > 3 files changed, 20 insertions(+), 14 deletions(-)
Seems good to me:
Reviewed-by: Brian Norris <computersforpeace@gmail.com>
| |