lkml.org 
[lkml]   [2018]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] f2fs: rework fault injection handling to avoid a warning
From
Date
On 2018/8/14 5:38, Arnd Bergmann wrote:
> When CONFIG_F2FS_FAULT_INJECTION is disabled, we get a warning about an
> unused label:
>
> fs/f2fs/segment.c: In function '__submit_discard_cmd':
> fs/f2fs/segment.c:1059:1: error: label 'submit' defined but not used [-Werror=unused-label]
>
> This could be fixed by adding another #ifdef around it, but the more
> reliable way of doing this seems to be to remove the other #ifdefs
> where that is easily possible.
>
> By defining time_to_inject() as a trivial stub, most of the checks for
> CONFIG_F2FS_FAULT_INJECTION can go away. This also leads to nicer
> formatting of the code.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,

\
 
 \ /
  Last update: 2018-08-14 08:07    [W:0.090 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site