lkml.org 
[lkml]   [2018]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] perf/hw_breakpoint: Enable breakpoint in modify_user_hw_breakpoint
On 08/10, Jiri Olsa wrote:
>
> --- a/kernel/events/hw_breakpoint.c
> +++ b/kernel/events/hw_breakpoint.c
> @@ -523,13 +523,11 @@ int modify_user_hw_breakpoint(struct perf_event *bp, struct perf_event_attr *att
> perf_event_disable(bp);
>
> err = modify_user_hw_breakpoint_check(bp, attr, false);
> - if (err)
> - return err;
>
> - if (!attr->disabled)
> + if (!bp->attr.disabled)
> perf_event_enable(bp);
>
> - return 0;
> + return err;
> }

Acked-by: Oleg Nesterov <oleg@redhat.com>

\
 
 \ /
  Last update: 2018-08-14 12:33    [W:0.089 / U:2.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site