lkml.org 
[lkml]   [2018]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 4/6] iio:adxl372: Add FIFO and interrupts support
Hi Stefan,

I love your patch! Perhaps something to improve:

url: https://github.com/0day-ci/linux/commits/Stefan-Popa/iio-accel-Add-adxl372-driver/20180807-050955
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg

smatch warnings:
drivers/iio/accel/adxl372.c:704 adxl372_buffer_postenable() error: buffer overflow 'adxl372_axis_lookup_table' 7 <= 7 (assuming for loop doesn't break)

# https://github.com/0day-ci/linux/commit/021923033c19a85fa8f99993de6591691ee67b1a
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 021923033c19a85fa8f99993de6591691ee67b1a
vim +704 drivers/iio/accel/adxl372.c

02192303 Stefan Popa 2018-08-06 686
02192303 Stefan Popa 2018-08-06 687 static int adxl372_buffer_postenable(struct iio_dev *indio_dev)
02192303 Stefan Popa 2018-08-06 688 {
02192303 Stefan Popa 2018-08-06 689 struct adxl372_state *st = iio_priv(indio_dev);
02192303 Stefan Popa 2018-08-06 690 unsigned int mask;
02192303 Stefan Popa 2018-08-06 691 int i, ret;
02192303 Stefan Popa 2018-08-06 692
02192303 Stefan Popa 2018-08-06 693 ret = adxl372_set_interrupts(st, ADXL372_INT1_MAP_FIFO_FULL_MSK, 0);
02192303 Stefan Popa 2018-08-06 694 if (ret < 0)
02192303 Stefan Popa 2018-08-06 695 return ret;
02192303 Stefan Popa 2018-08-06 696
02192303 Stefan Popa 2018-08-06 697 mask = *indio_dev->active_scan_mask;
02192303 Stefan Popa 2018-08-06 698
02192303 Stefan Popa 2018-08-06 699 for (i = 0; i < ARRAY_SIZE(adxl372_axis_lookup_table); i++) {
02192303 Stefan Popa 2018-08-06 700 if (mask == adxl372_axis_lookup_table[i].bits)
02192303 Stefan Popa 2018-08-06 701 break;
02192303 Stefan Popa 2018-08-06 702 }
02192303 Stefan Popa 2018-08-06 703
02192303 Stefan Popa 2018-08-06 @704 st->fifo_format = adxl372_axis_lookup_table[i].fifo_format;
02192303 Stefan Popa 2018-08-06 705 st->fifo_set_size = bitmap_weight(indio_dev->active_scan_mask,
02192303 Stefan Popa 2018-08-06 706 indio_dev->masklength);
02192303 Stefan Popa 2018-08-06 707 /*
02192303 Stefan Popa 2018-08-06 708 * The 512 FIFO samples can be allotted in several ways, such as:
02192303 Stefan Popa 2018-08-06 709 * 170 sample sets of concurrent 3-axis data
02192303 Stefan Popa 2018-08-06 710 * 256 sample sets of concurrent 2-axis data (user selectable)
02192303 Stefan Popa 2018-08-06 711 * 512 sample sets of single-axis data
02192303 Stefan Popa 2018-08-06 712 */
02192303 Stefan Popa 2018-08-06 713 if ((st->watermark * st->fifo_set_size) > ADXL372_FIFO_SIZE)
02192303 Stefan Popa 2018-08-06 714 st->watermark = (ADXL372_FIFO_SIZE / st->fifo_set_size);
02192303 Stefan Popa 2018-08-06 715
02192303 Stefan Popa 2018-08-06 716 st->fifo_mode = ADXL372_FIFO_STREAMED;
02192303 Stefan Popa 2018-08-06 717
02192303 Stefan Popa 2018-08-06 718 ret = adxl372_configure_fifo(st);
02192303 Stefan Popa 2018-08-06 719 if (ret < 0) {
02192303 Stefan Popa 2018-08-06 720 st->fifo_mode = ADXL372_FIFO_BYPASSED;
02192303 Stefan Popa 2018-08-06 721 adxl372_set_interrupts(st, 0, 0);
02192303 Stefan Popa 2018-08-06 722 return ret;
02192303 Stefan Popa 2018-08-06 723 }
02192303 Stefan Popa 2018-08-06 724
02192303 Stefan Popa 2018-08-06 725 return iio_triggered_buffer_postenable(indio_dev);
02192303 Stefan Popa 2018-08-06 726 }
02192303 Stefan Popa 2018-08-06 727

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

\
 
 \ /
  Last update: 2018-08-10 09:22    [W:0.109 / U:13.080 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site