lkml.org 
[lkml]   [2018]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] ACPI: nfit: remove redundant assignment if nfit_mem found
Date

On Thu, 2018-08-02 at 04:44 -0400, oceanhehy@gmail.com wrote:
> From: Ocean He <hehy1@lenovo.com>
>
> When nfit_mem is found via list_for_each_entry, it has already been
> assigned valid value. There is no need to assign it again in the
> following
> codes.
>
> Signed-off-by: Ocean He <hehy1@lenovo.com>
> ---
> v1: https://patchwork.kernel.org/patch/10553277/
> v2: Sorry for noise. I got an email problem, so I have to resend to
> loop
> linux-nvdimm@lists.01.org.
>
> drivers/acpi/nfit/core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 7c47900..85dde54 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -1048,9 +1048,7 @@ static int __nfit_mem_init(struct
> acpi_nfit_desc *acpi_desc,
> break;
> }
>
> - if (found)
> - nfit_mem = found;
> - else {
> + if (!found) {

Hi Ocean,

While this is technically correct, the old way was easier to read. We
loop through and find the matching handle. If we found one, then
nfit_mem was whatever was found. If not, we allocate it.

With this change, one has to go grok the list_for_.. loop to figure out
where nfit_mem is coming from. I'd personally prefer to keep the
existing way..

> nfit_mem = devm_kzalloc(acpi_desc->dev,
> sizeof(*nfit_mem),
> GFP_KERNEL);
> if (!nfit_mem)
\
 
 \ /
  Last update: 2018-08-11 01:46    [W:0.034 / U:1.884 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site