lkml.org 
[lkml]   [2018]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v4 2/2] tpm: add support for nonblocking operation
    From
    Date
    On Fri, 2018-08-10 at 11:21 -0700, Tadeusz Struk wrote:
    > and the feedback I got from Jason was:
    >
    > "I wonder if it is worth creating this when the first file is
    > opened.. Lots of systems have TPMs but few use the userspace.."
    >
    > so I changed this to allocate the WQ on first open. I think it makes
    > sense, but I leave it to you to decide.

    If the reason is to not create a wq unless it's needed, shouldn't the
    condition actually be first open with flag O_NONBLOCK?

    James

    \
     
     \ /
      Last update: 2018-08-10 20:49    [W:4.562 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site