lkml.org 
[lkml]   [2018]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC v7 PATCH 2/4] mm: mmap: zap pages with read mmap_sem in munmap
From
Date


On 8/10/18 10:57 AM, Matthew Wilcox wrote:
> On Fri, Aug 10, 2018 at 07:36:01AM +0800, Yang Shi wrote:
>> +/*
>> + * Zap pages with read mmap_sem held
>> + *
>> + * uf is the list for userfaultfd
>> + */
>> +static int do_munmap_zap_rlock(struct mm_struct *mm, unsigned long start,
>> + size_t len, struct list_head *uf)
> I don't like the name here. We aren't zapping rlocks, we're zapping
> pages. Not sure what to call it though ...

It may look ambiguous, it means "zap with rlock", but I don't think
anyone would expect we are zapping locks.

Thanks,
Yang


\
 
 \ /
  Last update: 2018-08-10 20:27    [W:0.031 / U:7.876 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site