lkml.org 
[lkml]   [2018]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 02/16] staging: gasket: core: remove debug log that could crash
Reviewed-by: Rob Springer <rspringer@google.com>

On Fri, Aug 10, 2018 at 9:56 AM Rob Springer <rspringer@google.com> wrote:
>
> Revewed-by: Rob Springer <rspringer@google.com>
>
> On Thu, Aug 9, 2018 at 8:21 PM Todd Poynor <toddpoynor@gmail.com> wrote:
>>
>> From: Todd Poynor <toddpoynor@google.com>
>>
>> A debug log in gasket_alloc_dev() is issued regardless of whether the
>> device pointer used returned success or error. The log isn't that
>> useful anyway, remove it.
>>
>> Signed-off-by: Todd Poynor <toddpoynor@google.com>
>> ---
>> drivers/staging/gasket/gasket_core.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c
>> index d12ab560411f7..37d14e30ffa21 100644
>> --- a/drivers/staging/gasket/gasket_core.c
>> +++ b/drivers/staging/gasket/gasket_core.c
>> @@ -234,8 +234,6 @@ static int gasket_alloc_dev(struct gasket_internal_desc *internal_desc,
>> dev_info->device = device_create(internal_desc->class, parent,
>> dev_info->devt, gasket_dev, dev_info->name);
>>
>> - dev_dbg(dev_info->device, "Gasket device allocated.\n");
>> -
>> /* cdev has not yet been added; cdev_added is 0 */
>> dev_info->gasket_dev_ptr = gasket_dev;
>> /* ownership is all 0, indicating no owner or opens. */
>> --
>> 2.18.0.597.ga71716f1ad-goog
>>

\
 
 \ /
  Last update: 2018-08-10 18:58    [W:0.114 / U:1.864 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site