Messages in this thread | | | From | Rashmica Gupta <> | Date | Sat, 11 Aug 2018 00:25:39 +1000 | Subject | Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory |
| |
On Fri, Aug 10, 2018 at 11:00 PM, Michal Hocko <mhocko@kernel.org> wrote: > On Fri 10-08-18 16:55:40, Rashmica Gupta wrote: > [...] >> Most memory hotplug/hotremove seems to be block or section based, and >> always adds and removes memory at the same place. > > Yes and that is hard wired to the memory hotplug code. It is not easy to > make it work outside of section units restriction. So whatever your > memtrace is doing and if it relies on subsection hotplug it cannot > possibly work with the current code. > > I didn't get to review your patch but if it is only needed for an > unmerged code I would rather incline to not merge it unless it is a > clear win to the resource subsystem. A report from Oscar shows that this > is not the case though. >
Yup, makes sense. I'll work on it and see if I can not break things.
> -- > Michal Hocko > SUSE Labs
| |