Messages in this thread | | | Subject | Re: [PATCH v2 00/29] at24: remove at24_platform_data | From | Srinivas Kandagatla <> | Date | Fri, 10 Aug 2018 09:41:49 +0100 |
| |
On 10/08/18 09:04, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > This is a follow-up to the previously rejected series[1] which partially > removed the at24_platform_data structure. After further development and > taking reviews into account, this series finally removes that struct > completely but not without touching many different parts of the code > base. > > Since I took over maintainership of the at24 driver I've been working > towards removing at24_platform_data in favor for device properties. > > DaVinci is the only platform that's still using it - all other users > have already been converted. > > One of the obstacles in case of DaVinci is removing the setup() callback > from the pdata struct, the only user of which are some davinci boards. > > Most boards use the EEPROM to store the MAC address. This series adds > support for cell lookups to the nvmem framework, registers relevant > cells for all users, adds nvmem support to eth_platform_get_mac_address(), > converts davinci_emac driver to using it and replaces at24_platform_data > with device properties. > > There's also one board (da850-evm) which uses MTD for reading the MAC > address. I used the patch from Alban Bedel's previous submission[2] to > add support for nvmem to the MTD framework. Since this user doesn't > need device tree, I dropped Alban's patches modifying the DT bindings. > We can add that later once an agreement is reached. For the time being > MTD devices are registered as nvmem devices and we're registering the > mac-address cell using the cell lookup mechanism. > > This series adds a blocking notifier chain to the nvmem framework, so > that we can keep the EEPROM reading code in the mityomapl138 board file > with only slight modifications. > > I also included some minor fixes to the modified code. > > Tested on da850-evm & dm365-evm. > > [1] https://lkml.org/lkml/2018/6/29/153 > [2] https://lkml.org/lkml/2018/3/24/312 > ...
> Bartosz Golaszewski (28): > nvmem: add support for cell lookups > Documentation: nvmem: document lookup entries > nvmem: add a notifier chain > nvmem: provide nvmem_dev_name() > nvmem: remove the name field from struct nvmem_device > > Documentation/nvmem/nvmem.txt | 28 +++++ .. > drivers/nvmem/core.c | 106 ++++++++++++++++-
nvmem parts looks good to me other then few trivial kernel doc comments! I can either Ack those patches or Send them after rc3-4 to Greg KH as 4.20 material.
Thanks srini
>
| |