Messages in this thread | | | Date | Wed, 1 Aug 2018 13:32:06 -0400 | From | Johannes Weiner <> | Subject | Re: [PATCH 2/3] mm, oom: refactor oom_kill_process() |
| |
On Mon, Jul 30, 2018 at 11:00:59AM -0700, Roman Gushchin wrote: > oom_kill_process() consists of two logical parts: the first one is > responsible for considering task's children as a potential victim and > printing the debug information. The second half is responsible for > sending SIGKILL to all tasks sharing the mm struct with the given victim. > > This commit splits oom_kill_process() with an intention to re-use the the > second half: __oom_kill_process(). > > The cgroup-aware OOM killer will kill multiple tasks belonging to the > victim cgroup. We don't need to print the debug information for the each > task, as well as play with task selection (considering task's children), > so we can't use the existing oom_kill_process(). > > Link: http://lkml.kernel.org/r/20171130152824.1591-2-guro@fb.com > Signed-off-by: Roman Gushchin <guro@fb.com> > Acked-by: Michal Hocko <mhocko@suse.com> > Acked-by: Johannes Weiner <hannes@cmpxchg.org> > Acked-by: David Rientjes <rientjes@google.com> > Cc: Vladimir Davydov <vdavydov.dev@gmail.com> > Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> > Cc: David Rientjes <rientjes@google.com> > Cc: Tejun Heo <tj@kernel.org> > Cc: Michal Hocko <mhocko@kernel.org> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This is pretty straight-forward.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
| |