lkml.org 
[lkml]   [2018]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.17 038/336] net: hns3: Fix for VF mailbox cannot receiving PF response
    Date
    4.17-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Xi Wang <wangxi11@huawei.com>

    [ Upstream commit 1819e40908ee76c7219287224c22c772556c927e ]

    When the VF frequently switches the CMDQ interrupt, if the CMDQ_SRC is not
    cleared, the VF will not receive the new PF response after the interrupt
    is re-enabled, the corresponding log is as follows:

    [ 317.482222] hns3 0000:00:03.0: VF could not get mbx resp(=0) from PF
    in 500 tries
    [ 317.483137] hns3 0000:00:03.0: VF request to get tqp info from PF
    failed -5

    This patch fixes this problem by clearing CMDQ_SRC before enabling
    interrupt and syncing pending IRQ handlers after disabling interrupt.

    Fixes: e2cb1dec9779 ("net: hns3: Add HNS3 VF HCL(Hardware Compatibility Layer) Support")
    Signed-off-by: Xi Wang <wangxi11@huawei.com>
    Signed-off-by: Peng Li <lipeng321@huawei.com>
    Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
    +++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
    @@ -1441,6 +1441,8 @@ static int hclgevf_misc_irq_init(struct
    return ret;
    }

    + hclgevf_clear_event_cause(hdev, 0);
    +
    /* enable misc. vector(vector 0) */
    hclgevf_enable_vector(&hdev->misc_vector, true);

    @@ -1451,6 +1453,7 @@ static void hclgevf_misc_irq_uninit(stru
    {
    /* disable misc vector(vector 0) */
    hclgevf_enable_vector(&hdev->misc_vector, false);
    + synchronize_irq(hdev->misc_vector.vector_irq);
    free_irq(hdev->misc_vector.vector_irq, hdev);
    hclgevf_free_vector(hdev, 0);
    }

    \
     
     \ /
      Last update: 2018-08-01 19:40    [W:4.058 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site