lkml.org 
[lkml]   [2018]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.17 216/336] scsi: megaraid: silence a static checker bug
    Date
    4.17-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 27e833dabab74ee665e487e291c9afc6d71effba ]

    If we had more than 32 megaraid cards then it would cause memory
    corruption. That's not likely, of course, but it's handy to enforce it
    and make the static checker happy.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/scsi/megaraid.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/scsi/megaraid.c
    +++ b/drivers/scsi/megaraid.c
    @@ -4199,6 +4199,9 @@ megaraid_probe_one(struct pci_dev *pdev,
    int irq, i, j;
    int error = -ENODEV;

    + if (hba_count >= MAX_CONTROLLERS)
    + goto out;
    +
    if (pci_enable_device(pdev))
    goto out;
    pci_set_master(pdev);

    \
     
     \ /
      Last update: 2018-08-01 19:22    [W:6.397 / U:0.440 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site