Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH net-next] rxrpc: remove redundant variables 'xcall','sp' and 'did_discard' | Date | Wed, 01 Aug 2018 09:28:14 +0100 |
| |
YueHaibing <yuehaibing@huawei.com> wrote:
> while (*pp) { > parent = *pp; > - xcall = rb_entry(parent, struct rxrpc_call, sock_node); > if (user_call_ID < call->user_call_ID) > pp = &(*pp)->rb_left; > else if (user_call_ID > call->user_call_ID)
No, this is an actual bug. The if-conditions should be using xcall-> not call->.
> - sp = rxrpc_skb(skb);
Yeah, that's fine.
> - did_discard = true;
Hmmm... It looks like I intended something with this, but I don't remember what now. I think it can be removed.
David
| |