lkml.org 
[lkml]   [2018]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH net-next] rxrpc: remove redundant variables 'xcall','sp' and 'did_discard'
Date
YueHaibing <yuehaibing@huawei.com> wrote:

> while (*pp) {
> parent = *pp;
> - xcall = rb_entry(parent, struct rxrpc_call, sock_node);
> if (user_call_ID < call->user_call_ID)
> pp = &(*pp)->rb_left;
> else if (user_call_ID > call->user_call_ID)

No, this is an actual bug. The if-conditions should be using xcall-> not
call->.

> - sp = rxrpc_skb(skb);

Yeah, that's fine.

> - did_discard = true;

Hmmm... It looks like I intended something with this, but I don't remember
what now. I think it can be removed.

David

\
 
 \ /
  Last update: 2018-08-01 10:29    [W:0.067 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site